Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @testing-library/jest-dom from 5.11.9 to 5.11.10 #2314

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2021

Bumps @testing-library/jest-dom from 5.11.9 to 5.11.10.

Release notes

Sourced from @​testing-library/jest-dom's releases.

v5.11.10

5.11.10 (2021-03-25)

Bug Fixes

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 1, 2021
@dependabot dependabot bot requested a review from a team April 1, 2021 09:03
@marians
Copy link
Member

marians commented Apr 1, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/testing-library/jest-dom-5.11.10 branch 3 times, most recently from f3aeb48 to b3bf25b Compare April 7, 2021 05:12
@marians
Copy link
Member

marians commented Apr 7, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/testing-library/jest-dom-5.11.10 branch from b3bf25b to d0145fa Compare April 7, 2021 10:17
@marians
Copy link
Member

marians commented Apr 7, 2021

@giantswarm/chapter-front-end The tests for this branch fail repeatedly. It seems to be about mock requests still running, which is not related to the change in the dependency. What can we do?

@oponder
Copy link
Contributor

oponder commented Apr 7, 2021

I took a look, the error is a bit misleading. A test expectation fails because of a change to .toContainHTML, this means the test is halted and then the nock never gets the request it expected.

That is still surfaced, even though the real problem is the failure of the expectation.

I'm not sure why yet, but something about our test does not play nicely with what they thought was just a patch level fix: testing-library/jest-dom#349

The failing expectations look like:

expect(nodePools[0]).toContainHTML(nodePoolNameEl);

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/testing-library/jest-dom-5.11.10 branch from d0145fa to e47543b Compare April 8, 2021 05:13
@marians
Copy link
Member

marians commented Apr 8, 2021

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/testing-library/jest-dom-5.11.10 branch from e47543b to 941acb4 Compare April 8, 2021 08:43
@marians
Copy link
Member

marians commented Apr 8, 2021

@dependabot close

@dependabot dependabot bot closed this Apr 8, 2021
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/testing-library/jest-dom-5.11.10 branch April 8, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants