Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toBeVisible implies toBeInTheDocument #339

Merged
merged 5 commits into from Feb 10, 2021

Conversation

calebeby
Copy link
Contributor

@calebeby calebeby commented Feb 5, 2021

What/Why:

#338

Checklist:

  • Documentation
  • Tests
  • Updated Type Definitions - The .d.ts is not in this repo
  • Ready to be merged

cc @gnapse

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #339 (fc97079) into main (a750063) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #339   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          537       539    +2     
  Branches       195       197    +2     
=========================================
+ Hits           537       539    +2     
Impacted Files Coverage Δ
src/to-be-visible.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a750063...c4ee395. Read the comment docs.

Copy link
Member

@gnapse gnapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Left a couple of nit-picky comments. Let me know if/when you address them and we're good to go.

README.md Outdated Show resolved Hide resolved
src/__tests__/to-be-visible.js Outdated Show resolved Hide resolved
@calebeby
Copy link
Contributor Author

calebeby commented Feb 9, 2021

@gnapse Should be all set!

@gnapse gnapse merged commit f687eb7 into testing-library:main Feb 10, 2021
@gnapse
Copy link
Member

gnapse commented Feb 10, 2021

@all-contributors please add @calebeby for code, test

@allcontributors
Copy link
Contributor

@gnapse

I've put up a pull request to add @calebeby! 🎉

@calebeby calebeby deleted the toBeVisible-in-the-document branch February 10, 2021 02:31
@github-actions
Copy link

🎉 This PR is included in version 5.11.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants