Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.11 to GHA #590

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Add Python 3.11 to GHA #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
python-version: [2.7, "3.7", "3.8", "3.9", "3.10"]
python-version: [2.7, "3.7", "3.8", "3.9", "3.10", "3.11"]
os: [ubuntu-latest]

steps:
Expand Down
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
# Shortcuts for various tasks (UNIX only).
# To use a specific Python version run:
# $ make install PYTHON=python3.3
# $ make install PYTHON=python3.7

PYTHON = python3
Comment on lines +3 to 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be PYTHON ?= python3 ?
https://www.gnu.org/software/make/manual/html_node/Setting.html

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked doc says:

If you’d like a variable to be set to a value only if it’s not already set, then you can use the shorthand operator ‘?=’ instead of ‘=’.

PYTHON is already set, so there's no need to use ?=

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, true. I just did a test with this Makefile:

PYTHON = python3
MYTHON ?= python3

.PHONY: test

test:
	@echo "PYTHON is set to $(PYTHON)"
	@echo "MYTHON is set to $(MYTHON)"

which gives these results:

$ make test PYTHON=python3.8 MYTHON=python3.8
PYTHON is set to python3.8
MYTHON is set to python3.8
$ PYTHON=python3.8 MYTHON=python3.8 make test
PYTHON is set to python3
MYTHON is set to python3.8

so this was just a gap in my understanding of Makefile variables. Sorry!

TSCRIPT = pyftpdlib/test/runner.py
ARGS =
DEV_DEPS = \
git+https://github.com/PyCQA/autoflake.git \
autoflake \
cffi \
check-manifest \
coverage \
flake8 \
flake8==5.0.4 \
flake8-blind-except \
flake8-bugbear \
flake8-debugger \
Expand Down