Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][YD-4110] Support v2.8.1 of the Android SDK #18

Merged
merged 2 commits into from
Mar 15, 2022
Merged

[TASK][YD-4110] Support v2.8.1 of the Android SDK #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
390340d
Upgrade `metro-react-native-babel-preset` to 0.59.0
mariasenosiain Mar 9, 2022
1719a96
Support v2.8.1 of the Android YDS SDK
mircea-yoti Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ android {
defaultConfig {
minSdkVersion safeExtGet('minSdkVersion', 21)
targetSdkVersion safeExtGet('targetSdkVersion', 29)
versionCode 190
versionName "1.9.0"
versionCode 191
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
versionCode 191
versionCode 1100

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, updating to 1100 was my initial impulse. But, the thing is, when we'll launch RN version 2.0.0, then I can't downgrade the versionCode to 200. Per the docs:

  • versionCode — A positive integer used as an internal version number. This number is used only to determine whether one version is more recent than another, with higher numbers indicating more recent versions. This is not the version number shown to users
  • Typically, you would release the first version of your app with versionCode set to 1, then monotonically increase the value with each release, regardless of whether the release constitutes a major or minor release. This means that the versionCode value does not necessarily have a strong resemblance to the app release version that is visible to the user

versionName "1.10.0"
ndk {
abiFilters "armeabi-v7a", "x86"
}
Expand All @@ -38,10 +38,10 @@ android {
dependencies {
//noinspection GradleDynamicVersion
implementation "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}"
implementation 'com.yoti.mobile.android.sdk:yoti-sdk-doc-scan:2.7.0'
implementation 'com.yoti.mobile.android.sdk:yoti-sdk-doc-scan-sup:2.7.0'
implementation 'com.yoti.mobile.android.sdk:yoti-sdk-liveness-zoom:2.7.0'
implementation 'com.yoti.mobile.android.sdk:yoti-sdk-facecapture:2.7.0'
implementation 'com.yoti.mobile.android.sdk:yoti-sdk-doc-scan:2.8.1'
implementation 'com.yoti.mobile.android.sdk:yoti-sdk-doc-scan-sup:2.8.1'
implementation 'com.yoti.mobile.android.sdk:yoti-sdk-liveness-zoom:2.8.1'
implementation 'com.yoti.mobile.android.sdk:yoti-sdk-facecapture:2.8.1'
}

allprojects {
Expand Down
4 changes: 2 additions & 2 deletions example/ios/example.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@
INFOPLIST_FILE = example/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
MARKETING_VERSION = 1.9.0;
MARKETING_VERSION = 1.10.0;
OTHER_LDFLAGS = (
"$(inherited)",
"-ObjC",
Expand Down Expand Up @@ -940,7 +940,7 @@
INFOPLIST_FILE = example/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
MARKETING_VERSION = 1.9.0;
MARKETING_VERSION = 1.10.0;
OTHER_LDFLAGS = (
"$(inherited)",
"-ObjC",
Expand Down
2 changes: 1 addition & 1 deletion example/ios/example/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.9.0</string>
<string>1.10.0</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand Down
4 changes: 2 additions & 2 deletions example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "example",
"version": "1.9.0",
"version": "1.10.0",
"private": true,
"scripts": {
"android": "react-native run-android",
Expand All @@ -21,7 +21,7 @@
"babel-jest": "^25.1.0",
"eslint": "^6.8.0",
"jest": "^25.1.0",
"metro-react-native-babel-preset": "^0.58.0",
"metro-react-native-babel-preset": "^0.59.0",
"react-test-renderer": "16.9.0"
},
"jest": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@getyoti/react-native-yoti-doc-scan",
"version": "1.9.0",
"version": "1.10.0",
"description": "Yoti Doc Scan for React Native",
"main": "YotiDocScan.js",
"license": "SEE LICENSE IN LICENSE",
Expand Down