[TASK][YD-4110] Support v2.8.1 of the Android SDK #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version was causing a crash when the App was launched in both: iOS & Android More info here: babel/babel#14139 (comment) Related to YD-4110
- Update the Android YDS SDK version to 2.8.1 - Update RN to 1.10.0 Related to YD-4110
mariasenosiain
approved these changes
Mar 10, 2022
asklausen
reviewed
Mar 10, 2022
| @@ -11,8 +11,8 @@ android { | |||
| defaultConfig { | |||
| minSdkVersion safeExtGet('minSdkVersion', 21) | |||
| targetSdkVersion safeExtGet('targetSdkVersion', 29) | |||
| versionCode 190 | |||
| versionName "1.9.0" | |||
| versionCode 191 | |||
There was a problem hiding this comment.
Suggested change
| versionCode 191 | |
| versionCode 1100 |
There was a problem hiding this comment.
Yeah, updating to 1100 was my initial impulse. But, the thing is, when we'll launch RN version 2.0.0, then I can't downgrade the versionCode to 200. Per the docs:
- versionCode — A positive integer used as an internal version number. This number is used only to determine whether one version is more recent than another, with higher numbers indicating more recent versions. This is not the version number shown to users
- Typically, you would release the first version of your app with versionCode set to 1, then monotonically increase the value with each release, regardless of whether the release constitutes a major or minor release. This means that the versionCode value does not necessarily have a strong resemblance to the app release version that is visible to the user
asklausen
approved these changes
Mar 10, 2022
asklausen
added
duplicate
|
Tested. |
Zzhelyaz
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
metro-react-native-babel-presetto 0.59.0. The previous version was causing a crash when running the app on both Android and iOS. More info here.External References (e.g. Jira / Zeplin / Confluence)
YD-4110