Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic PR to bump sentry-cli on new releases #7

Closed
4 tasks done
bruno-garcia opened this issue May 10, 2022 · 11 comments
Closed
4 tasks done

Automatic PR to bump sentry-cli on new releases #7

bruno-garcia opened this issue May 10, 2022 · 11 comments

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented May 10, 2022

Basically a dependabot for sentry-cli on our SDKs/Plugins. The goal is to have our CI run against the latest versions of sentry-cli and avoid issues where we skip al the beta phases (e.g: sentry-cli 2.0.0).

Another goal is to stop checking-in Sentry CLI but to fetch that in CI before running tests and bundling the final package.
Like this; https://github.com/getsentry/sentry-android-gradle-plugin/pull/262/files

@bruno-garcia
Copy link
Member Author

@vaind
Copy link
Collaborator

vaind commented May 31, 2022

existing sentry-unity issue: getsentry/sentry-unity#674

@bruno-garcia
Copy link
Member Author

@denrase is working on tests for fastlane plugin first, then will create an automation for that, and we can see about gradle, unity, dart, etc

@vaind
Copy link
Collaborator

vaind commented Jun 20, 2022

I've thought about this shortly today after updating the scripts in sentry-unity. I'm thinking of adding another reusable workflow to https://github.com/getsentry/github-workflows - similar to the submodule updater.

The workflows inputs could be:

  • a file where we store a version (ideally just a plain text file)
  • and a repo URL to check for tags/releases/prereleases (in this case it would point to sentry-cli, but it's generic so can be used for other dependencies)

The output would be: update the version text file, create a changelog entry & create a PR.

I think we can tune this approach so that it could be triggered for pre-releases.

@vaind
Copy link
Collaborator

vaind commented Jun 24, 2022

OK, so the workflow to update the CLI is here: getsentry/github-workflows#4
And you can see the .properties file needed in sentry-unity: getsentry/sentry-unity#855

@vaind
Copy link
Collaborator

vaind commented Jun 27, 2022

I can't update the original issue description (thus click the checkboxes), so here's an update:

@marandaneto
Copy link

@denrase
Copy link
Collaborator

denrase commented Aug 1, 2022

Created a PR in order to amend the automatically created CLI PR

getsentry/github-workflows#18

We use this in sentry-fastlane-plugin to commit the accociated binaries when a new version of sentry-cli is available in the same automatically created PR.

getsentry/sentry-fastlane-plugin#144
getsentry/sentry-fastlane-plugin#156

@denrase
Copy link
Collaborator

denrase commented Aug 22, 2022

This was merged for the flutter plugin getsentry/sentry-fastlane-plugin#144

@denrase
Copy link
Collaborator

denrase commented Aug 30, 2022

Created a PR to add integration tests to the android gradle plugin, similar to what we did for the fastlane plugin.

getsentry/sentry-android-gradle-plugin#371

@marandaneto
Copy link

@vaind I believe this is done already, can we close this?

@vaind vaind closed this as completed Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants