Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enha: upload-dif integration test #128

Merged
merged 15 commits into from
Jun 20, 2022

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jun 7, 2022

#skip-changelog

This PR adds an integration test for upload-diff action.

  • Action is called through a fastlane lane
  • A mock server returning expected values for sentry-cli calls
  • Bumps required ruby version to 2.6.0
    • Test action required this

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the approach. What is missing from finishing this PR @denrase?

@denrase
Copy link
Collaborator Author

denrase commented Jun 14, 2022

@philipphofmann Automation to run this in CI and maybe also call other commands, but those can be sep. PRs.

@denrase denrase marked this pull request as ready for review June 14, 2022 14:32
@denrase denrase requested a review from marandaneto June 14, 2022 14:48
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀. Thanks @denrase.

@denrase
Copy link
Collaborator Author

denrase commented Jun 15, 2022

Info: This relates to getsentry/team-mobile#7

@philipphofmann philipphofmann merged commit ad5b786 into master Jun 20, 2022
@philipphofmann philipphofmann deleted the enha/upload-dif-integration-test branch June 20, 2022 13:27
philipphofmann pushed a commit that referenced this pull request Jul 12, 2022
This PR expands on the work of @vaind and PR #128 and adds an integration test for the remaining actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants