Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enha: More Integration Tests #130

Merged
merged 32 commits into from
Jul 12, 2022
Merged

Enha: More Integration Tests #130

merged 32 commits into from
Jul 12, 2022

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jun 27, 2022 •
edited

#skip-changelog

This PR expands on the work of @vaind and PR #128 and adds an integration test for the remaining actions.

Also relates to getsentry/team-mobile#7

Denis Andrašec and others added 21 commits June 7, 2022 14:31
add sample test server
4c44412
@denrase
add integration_test lane
dedc159
@denrase
refactor script and check exit codes
af90fe1
@denrase
add action for integration test
17513f8
@denrase
set python version
a9e3e08
@denrase
setup fastlane action
17bcdcc
@denrase
intall fastlane
d0721eb
@denrase
bump ruby version
76906da
@denrase
use other ruby action
1592681
@denrase
run on macos
9fe9cd6
@denrase
Test failing fastlane call...
16c34b6
@denrase
revert test run
1c3d7af
@denrase
Run tests with ruby version 2.5
09880cb
@denrase
Bump required ruby version
b98e57e
@denrase
rename job
2a86754
@denrase
add create release integration test
3ea6b68
@denrase
add test for set commits
234ab16
@denrase
add integration test for deploy
0de86c4
@denrase
add upload file integration test
d866ec5
@denrase
test sentry_upload_sourcemap, sentry_upload_proguard
4148538
@denrase
Merge branch 'master' into enha/more-integration-tests
6a09143 
# Conflicts:
#	fastlane/Fastfile
#	integration.sh
#	script/integration-test-server.py
@philipphofmann
Copy link
Member

I'm looking forward to this PR being finished 💪

@denrase denrase marked this pull request as ready for review June 28, 2022 12:13
philipphofmann
philipphofmann reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, two minor comments.

script/integration-test-server.py Outdated Show resolved Hide resolved
script/integration-test-server.py Outdated Show resolved Hide resolved
bruno-garcia
bruno-garcia reviewed Jul 5, 2022
View reviewed changes
integration.sh Outdated Show resolved Hide resolved
philipphofmann
philipphofmann approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀, thanks @denrase.

@philipphofmann philipphofmann merged commit d14fc64 into master Jul 12, 2022
@philipphofmann philipphofmann deleted the enha/more-integration-tests branch July 12, 2022 11:52
@philipphofmann philipphofmann mentioned this pull request Jul 12, 2022
Closed
@bruno-garcia bruno-garcia mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@denrase @philipphofmann @bruno-garcia