Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ErrorListener not capturing events when Hub is not instantiated yet #243

Merged
merged 1 commit into from Sep 23, 2019
Merged

Fix ErrorListener not capturing events when Hub is not instantiated yet #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/EventListener/ErrorListener.php
View file
Open in desktop
Expand Up @@ -2,12 +2,25 @@

namespace Sentry\SentryBundle\EventListener;

use Sentry\State\HubInterface;
use Symfony\Component\Console\Event\ConsoleErrorEvent;
use Symfony\Component\Console\Event\ConsoleExceptionEvent;
use Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent;

final class ErrorListener
{
/** @var HubInterface */
private $hub;

/**
* ErrorListener constructor.
* @param HubInterface $hub
*/
public function __construct(HubInterface $hub)
{
$this->hub = $hub; // not used, needed to trigger instantiation
}

public function onKernelException(GetResponseForExceptionEvent $event): void
{
\Sentry\captureException($event->getException());
Expand Down
1 change: 1 addition & 0 deletions src/Resources/config/services.xml
View file
Open in desktop
Expand Up @@ -31,6 +31,7 @@
</service>

<service id="Sentry\SentryBundle\EventListener\ErrorListener" class="Sentry\SentryBundle\EventListener\ErrorListener" public="false">
<argument type="service" id="Sentry\State\HubInterface" />
<tag name="kernel.event_listener" event="kernel.exception" method="onKernelException" priority="%sentry.listener_priorities.request_error%" />
<!-- The following tag is done manually in PHP for BC with Symfony < 3.3 -->
<!-- <tag name="kernel.event_listener" event="console.error" method="onConsoleError" priority="%sentry.listener_priorities.console_error%" />-->
Expand Down