Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ErrorListener not capturing events when Hub is not instantiated yet #243

Merged
merged 1 commit into from Sep 23, 2019
Merged

Fix ErrorListener not capturing events when Hub is not instantiated yet #243

merged 1 commit into from Sep 23, 2019

Conversation

teohhanhui
Copy link
Contributor

Fixes #242

Jean85
Jean85 requested changes Sep 19, 2019
View reviewed changes
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Could you please add an entry in the changelog, under the "Unreleased" section?

Jean85
Jean85 approved these changes Sep 23, 2019
View reviewed changes
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're going to tag a release soon, I'll merge this anyway and add the changelog entry later 👍

@Jean85 Jean85 merged commit 4f4dcf0 into getsentry:master Sep 23, 2019
Jean85 added a commit that referenced this pull request Sep 23, 2019
@Jean85
Add changelog entry for #243
df3905e
@Jean85 Jean85 added this to the 3.2 milestone Sep 30, 2019
@teohhanhui teohhanhui deleted the fix/error-listener-hub-instantiation branch January 7, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Incorrect wiring of services resulting in no events being captured
2 participants
@teohhanhui @Jean85