New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow new excluded_exceptions config #123
Conversation
3b2d2fe
to
ac71fa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contibution!
To make this really work, we should require the next version of the client, so ^1.8.5
in the composer.json
. Since this edit will make your fork unusable, feel free to commit it later, after that release is done on the client.
Ehi @mcfedr, the Sentry SDK released a 1.9! Can you update your PRs? |
ac71fa3
to
f5bebed
Compare
f5bebed
to
b5082ea
Compare
Done, here is a new version with change to |
Thanks! Can you also open the same PR targeting the 1.x branch? I would like to backport it there too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.0.3 of the bundle got released, the 1.9 client too and it's correcly required... LGTM! 👍
@Jean85 Maybe its time for a new version of the bundle as this isn't in 2.0.3? Its been quite a while now... |
Ouch, I totally forgot about this, thanks for reminding me! I hope to merge it ASAP. |
We did not have any exceptions configured in When upgrade to v3, Sentry starts capturing |
Adds new config option from getsentry/sentry-php#583
Shouldn't be merged until a new release is made.
I'd really appreciate if this was picked into the 0.8.x branch as well, as I'm currently having to use that version for old php support... its horrible but true...