Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new excluded_exceptions config #123

Merged
merged 1 commit into from Jun 1, 2018

Conversation

mcfedr
Copy link
Contributor

@mcfedr mcfedr commented Apr 19, 2018

Adds new config option from getsentry/sentry-php#583

Shouldn't be merged until a new release is made.

I'd really appreciate if this was picked into the 0.8.x branch as well, as I'm currently having to use that version for old php support... its horrible but true...

@mcfedr mcfedr force-pushed the exclude-subclasses branch 4 times, most recently from 3b2d2fe to ac71fa3 Compare April 19, 2018 10:20
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contibution!
To make this really work, we should require the next version of the client, so ^1.8.5 in the composer.json. Since this edit will make your fork unusable, feel free to commit it later, after that release is done on the client.

@Jean85
Copy link
Collaborator

Jean85 commented May 23, 2018

Ehi @mcfedr, the Sentry SDK released a 1.9! Can you update your PRs?

@mcfedr
Copy link
Contributor Author

mcfedr commented May 24, 2018

Done, here is a new version with change to composer.json

@Jean85
Copy link
Collaborator

Jean85 commented May 25, 2018

Thanks! Can you also open the same PR targeting the 1.x branch? I would like to backport it there too.

Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.0.3 of the bundle got released, the 1.9 client too and it's correcly required... LGTM! 👍

@Jean85 Jean85 merged commit f67159f into getsentry:master Jun 1, 2018
@mcfedr
Copy link
Contributor Author

mcfedr commented Oct 29, 2018

@Jean85 Maybe its time for a new version of the bundle as this isn't in 2.0.3? Its been quite a while now...

Jean85 added a commit that referenced this pull request Oct 29, 2018
@Jean85
Copy link
Collaborator

Jean85 commented Oct 29, 2018

Ouch, I totally forgot about this, thanks for reminding me!
I've added this to the changelog: d39d086

I hope to merge it ASAP.

@rvanlaak
Copy link
Contributor

rvanlaak commented Nov 5, 2019

sentry-symfony started relying on the SDK's excluded_exceptions implementation, which is great but removes that the SDK is aware of Symfony exceptions that did get caught by default before.

We did not have any exceptions configured in excluded_exceptions yet, meaning that since skip_capture was removed in v3 the defaults the implementation used to rely on are gone.

When upgrade to v3, Sentry starts capturing HttpExceptionInterface instances. Did create PR #269 to restore the old behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants