Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new excluded_exceptions config #123

Merged
merged 1 commit into from Jun 1, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -21,7 +21,7 @@
"require": {
"php": "^7.1",
"jean85/pretty-package-versions": "^1.0",
"sentry/sentry": "^1.8",
"sentry/sentry": "^1.9",
"symfony/config": "^3.0||^4.0",
"symfony/console": "^3.3||^4.0",
"symfony/dependency-injection": "^3.0||^4.0",
Expand Down
3 changes: 3 additions & 0 deletions src/DependencyInjection/Configuration.php
Expand Up @@ -72,6 +72,9 @@ public function getConfigTreeBuilder()
->arrayNode('exclude')
->prototype('scalar')->end()
->end()
->arrayNode('excluded_exceptions')
->prototype('scalar')->end()
->end()
->scalarNode('http_proxy')->defaultNull()->end()
->arrayNode('extra')
->prototype('scalar')->end()
Expand Down
6 changes: 5 additions & 1 deletion test/DependencyInjection/SentryExtensionTest.php
Expand Up @@ -17,7 +17,7 @@

class SentryExtensionTest extends TestCase
{
private const SUPPORTED_SENTRY_OPTIONS_COUNT = 34;
private const SUPPORTED_SENTRY_OPTIONS_COUNT = 35;
private const LISTENER_TEST_PUBLIC_ALIAS = 'sentry.exception_listener.public_alias';

public function test_that_configuration_uses_the_right_default_values()
Expand Down Expand Up @@ -323,6 +323,10 @@ public function test_that_it_sets_all_sentry_options()
'test1',
'test2',
],
'excluded_exceptions' => [
'test3',
'test4',
],
'http_proxy' => 'http_proxy',
'extra' => [
'extra1' => 'extra1',
Expand Down