Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow new excluded_exceptions config for 0.8.x #124

Merged
merged 1 commit into from Jun 1, 2018

Conversation

mcfedr
Copy link
Contributor

@mcfedr mcfedr commented Apr 19, 2018

See also #123

Adds new config option from getsentry/sentry-php#583

Shouldn't be merged until a new release is made.

Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #123, we need to change the requirements, but it can wait.

@Jean85
Copy link
Collaborator

Jean85 commented Apr 19, 2018

Thanks for this porting! Can you open an other one for the 1.x branch?

@mcfedr
Copy link
Contributor Author

mcfedr commented Apr 19, 2018

Sure, Ill do it once there is a 1.8.5 release

@mcfedr
Copy link
Contributor Author

mcfedr commented May 24, 2018

Also bumped given 1.9 is now released

Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok, We can merge! 👍

@Jean85 Jean85 merged commit bb20610 into getsentry:releases/0.8.x Jun 1, 2018
Jean85 added a commit that referenced this pull request Jun 1, 2018
(cherry picked from commit a518e15)
Jean85 added a commit that referenced this pull request Jun 1, 2018
(cherry picked from commit a518e15)
Jean85 added a commit that referenced this pull request Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants