Skip to content

Commit

Permalink
http.request -> http.client
Browse files Browse the repository at this point in the history
  • Loading branch information
alekitto committed May 2, 2022
1 parent 941f6d3 commit ee883c0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/Tracing/HttpClient/AbstractTraceableHttpClient.php
Expand Up @@ -51,7 +51,7 @@ public function request(string $method, string $url, array $options = []): Respo
$options['headers'] = $headers;

$context = new SpanContext();
$context->setOp('http.request');
$context->setOp('http.client');
$context->setTags([
'http.method' => $method,
'http.url' => $url,
Expand Down
4 changes: 2 additions & 2 deletions tests/Tracing/HttpClient/TraceableHttpClientTest.php
Expand Up @@ -76,7 +76,7 @@ public function testRequest(): void

$this->assertCount(2, $spans);
$this->assertNull($spans[1]->getEndTimestamp());
$this->assertSame('http.request', $spans[1]->getOp());
$this->assertSame('http.client', $spans[1]->getOp());
$this->assertSame([
'http.method' => 'POST',
'http.url' => 'http://www.example.org/test-page',
Expand All @@ -87,7 +87,7 @@ public function testRequest(): void
$spans = $transaction->getSpanRecorder()->getSpans();
$this->assertCount(2, $spans);
$this->assertNotNull($spans[1]->getEndTimestamp());
$this->assertSame('http.request', $spans[1]->getOp());
$this->assertSame('http.client', $spans[1]->getOp());
$this->assertSame([
'http.method' => 'POST',
'http.url' => 'http://www.example.org/test-page',
Expand Down

0 comments on commit ee883c0

Please sign in to comment.