use http.url and http.method tags, instead of url and method

getsentry · Apr 15, 2022 · 941f6d3 · 941f6d3
1 parent a951725
commit 941f6d3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Tracing/HttpClient/AbstractTraceableHttpClient.php b/src/Tracing/HttpClient/AbstractTraceableHttpClient.php
@@ -53,8 +53,8 @@ public function request(string $method, string $url, array $options = []): Respo
             $context = new SpanContext();
             $context->setOp('http.request');
             $context->setTags([
-                'method' => $method,
-                'url' => $url,
+                'http.method' => $method,
+                'http.url' => $url,
             ]);
 
             $span = $parent->startChild($context);

diff --git a/tests/Tracing/HttpClient/TraceableHttpClientTest.php b/tests/Tracing/HttpClient/TraceableHttpClientTest.php
@@ -78,8 +78,8 @@ public function testRequest(): void
         $this->assertNull($spans[1]->getEndTimestamp());
         $this->assertSame('http.request', $spans[1]->getOp());
         $this->assertSame([
-            'method' => 'POST',
-            'url' => 'http://www.example.org/test-page',
+            'http.method' => 'POST',
+            'http.url' => 'http://www.example.org/test-page',
         ], $spans[1]->getTags());
 
         $response->getContent(false);
@@ -89,8 +89,8 @@ public function testRequest(): void
         $this->assertNotNull($spans[1]->getEndTimestamp());
         $this->assertSame('http.request', $spans[1]->getOp());
         $this->assertSame([
-            'method' => 'POST',
-            'url' => 'http://www.example.org/test-page',
+            'http.method' => 'POST',
+            'http.url' => 'http://www.example.org/test-page',
         ], $spans[1]->getTags());
     }