Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Failing Spec for Circular References in Hashes #952

Merged
merged 1 commit into from Mar 2, 2020
+1 −15
Merged

Drop Failing Spec for Circular References in Hashes #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ rvm:
- 2.4.9
- 2.5.7
- 2.6.5
- 2.7.0

env:
- RAILS_VERSION=4
Expand Down
15 changes: 0 additions & 15 deletions spec/raven/json_spec.rb
View file
Open in desktop
Expand Up @@ -60,20 +60,5 @@
JSON.parse(%({"example": "this is a utf8 or ASCII string"}).encode("US-ASCII"))
end.not_to raise_error
end

it "blows up on circular references" do
data = {}
data['data'] = data
data['ary'] = []
data['ary'].push('x' => data['ary'])
data['ary2'] = data['ary']
data['leave intact'] = { 'not a circular reference' => true }

if RUBY_PLATFORM == 'java'
expect { JSON.dump(data) }.to raise_error
else
expect { JSON.dump(data) }.to raise_error(SystemStackError)
end
end
end
end