Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Failing Spec for Circular References in Hashes #952

Merged
merged 1 commit into from Mar 2, 2020
Merged

Drop Failing Spec for Circular References in Hashes #952

merged 1 commit into from Mar 2, 2020
+1 −15

Commits on Mar 1, 2020

  1. Delete JSON spec for recursive hashes 

    The `JSON` 2.3.0 gem changed how parsing errors are raised. For example:

    require 'json'
    data = {}
    data['cycle'] = data
    JSON.dump(data)

With json v2.2.0:
This raises a `SystemStackError`.

With json v2.3.0:
This causes `fatal (machine stack overflow in critical region)`

Since the specs depend on 'SystemStackError' removing.
    @ksylvest
    ksylvest committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    863c030 View commit details
    Browse the repository at this point in the history