New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(core): Pre-beforeSendTransaction
cleanup
#6135
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6ae6b3a
clean up `beforeSend`'s docstring
lobsterkatie d169df4
fix error messages
lobsterkatie e3ac98b
clarify naming in `beforeSend` result validator and fix docstring
lobsterkatie 084cee4
proofread and format test names
lobsterkatie 1713eb6
s/`toBe`/`toEqual` where appropriate
lobsterkatie aa3c9a4
clarify spy variable name in node index tests
lobsterkatie 9f5b101
explain `captureException` spies
lobsterkatie 93ae271
simplify transaction name change test
lobsterkatie 82f68f7
use correct type in outcomes test
lobsterkatie 82e4572
modify rather than replacing events in mock `beforeSend`
lobsterkatie File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is just stuff we didn't need for the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. It has nothing to do with the name-change data we're testing, so in the end it's just noise.