Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(core): Pre-beforeSendTransaction cleanup #6135

Merged
merged 10 commits into from Nov 4, 2022
Merged

ref(core): Pre-beforeSendTransaction cleanup #6135

merged 10 commits into from Nov 4, 2022

Commits on Nov 3, 2022

  1. clean up beforeSend's docstring

    @lobsterkatie
    lobsterkatie committed Nov 3, 2022
    Copy the full SHA
    6ae6b3a View commit details
    Browse the repository at this point in the history

  2. fix error messages

    @lobsterkatie
    lobsterkatie committed Nov 3, 2022
    Copy the full SHA
    d169df4 View commit details
    Browse the repository at this point in the history

  3. clarify naming in beforeSend result validator and fix docstring

    @lobsterkatie
    lobsterkatie committed Nov 3, 2022
    Copy the full SHA
    e3ac98b View commit details
    Browse the repository at this point in the history

  4. proofread and format test names

    @lobsterkatie
    lobsterkatie committed Nov 3, 2022
    Copy the full SHA
    084cee4 View commit details
    Browse the repository at this point in the history

  5. s/toBe/toEqual where appropriate

    @lobsterkatie
    lobsterkatie committed Nov 3, 2022
    Copy the full SHA
    1713eb6 View commit details
    Browse the repository at this point in the history

  6. clarify spy variable name in node index tests

    @lobsterkatie
    lobsterkatie committed Nov 3, 2022
    Copy the full SHA
    aa3c9a4 View commit details
    Browse the repository at this point in the history

  7. explain captureException spies

    @lobsterkatie
    lobsterkatie committed Nov 3, 2022
    Copy the full SHA
    9f5b101 View commit details
    Browse the repository at this point in the history

  8. simplify transaction name change test

    @lobsterkatie
    lobsterkatie committed Nov 3, 2022
    Copy the full SHA
    93ae271 View commit details
    Browse the repository at this point in the history

  9. use correct type in outcomes test

    @lobsterkatie
    lobsterkatie committed Nov 3, 2022
    Copy the full SHA
    82f68f7 View commit details
    Browse the repository at this point in the history

  10. modify rather than replacing events in mock beforeSend

    @lobsterkatie
    lobsterkatie committed Nov 3, 2022
    Copy the full SHA
    82e4572 View commit details
    Browse the repository at this point in the history