Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use self to determine if we are in browser or worker #3994

Closed
wants to merge 1 commit into from

Conversation

mlahp7
Copy link

@mlahp7 mlahp7 commented Sep 20, 2021

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@AbhiPrasad
Copy link
Member

I'm surprised it's still breaking - though we might need to more aggressively check with getGlobalObject from @sentry/utils -> https://github.com/getsentry/sentry-javascript/blob/master/packages/utils/src/misc.ts#L31.

Anyway, thank you for bringing this up, we'll get on this.

@kamilogorek
Copy link
Contributor

Superseded by #3996 and merged into master, as well as covered by linter in #3999. Thanks for the PR nonetheless!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants