Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The on-by-default sendClientReports option breaks Web Workers #3992

Closed
4 of 9 tasks
mariyan-borisov opened this issue Sep 20, 2021 · 3 comments · Fixed by #3993
Closed
4 of 9 tasks

The on-by-default sendClientReports option breaks Web Workers #3992

mariyan-borisov opened this issue Sep 20, 2021 · 3 comments · Fixed by #3993

Comments

@mariyan-borisov
Copy link

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other:

Version:

6.13.0

Description

My service worker registration fails because document is not available in service workers:

Uncaught ReferenceError: document is not defined

I consider this a breaking API change. This option should either be off by default, or it should not break Web Workers.

@AbhiPrasad
Copy link
Member

Thanks for raising this issue. We have released a patch with the fix: https://www.npmjs.com/package/@sentry/browser/v/6.13.1. Please let us know if you encounter any other problems!

@mlahp7
Copy link

mlahp7 commented Sep 20, 2021

This fix is throwing some exceptions for us, and killing our workers. Any chance you can take a look at this fix?

#3994

image

@HazAT
Copy link
Member

HazAT commented Sep 21, 2021

@mlahp7 we already released 6.13.1 which should fix this, can you try to upgrade?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants