test(e2e): Enable ESM loader test #12020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
something didn't work in my PR which is also happening here:
I haven't figured it out yet. Otherwise I would have merged that PR ages ago. |
Why TF are e.g. vue-3 e2e tests failing, just because we are bumping node 18 😬 makes no sense to me... |
s1gr1d
approved these changes
May 14, 2024
mydea
added a commit
that referenced
this pull request
May 15, 2024
Extracted this out from #12020 For whatever reason, this does not seemed to play well with how we run the proxy server via ts-node. Looking into this more, this is actually not really necessary at all, so I just stripped this out in favor of just running the proxy as a `.mjs` file directly - works just as well!
fix? hm Bump node version Bump node version bump ci? hm . . test(e2e): Re-active & fix node-express-esm-loader test app
mydea
force-pushed
the
fn/node-esm-e2e-app
branch
from
d32dae9
to
24a1d94
Compare
andreiborza
pushed a commit
that referenced
this pull request
May 16, 2024
Extracted this out from #12020 For whatever reason, this does not seemed to play well with how we run the proxy server via ts-node. Looking into this more, this is actually not really necessary at all, so I just stripped this out in favor of just running the proxy as a `.mjs` file directly - works just as well!
andreiborza
pushed a commit
that referenced
this pull request
May 16, 2024
Supersedes #11912 I just cleaned up and renamed this to align with other things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #11912
I just cleaned up and renamed this to align with other things