-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): Update node version used for e2e tests #12031
Conversation
I did some more digging: For whatever reason, when I bump node from 18.18.2 to 18.19.0, some of the test apps start to fail with this: TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".ts" for /Users/francesco/git/sentry-javascript/dev-packages/e2e-tests/test-applications/vue-3/start-event-proxy.ts
at new NodeError (node:internal/errors:405:5)
at Object.getFileProtocolModuleFormat [as file:] (node:internal/modules/esm/get_format:136:11)
at defaultGetFormat (node:internal/modules/esm/get_format:182:36)
at defaultLoad (node:internal/modules/esm/load:101:20)
at nextLoad (node:internal/modules/esm/hooks:864:28)
at load (/Users/francesco/git/sentry-javascript/dev-packages/e2e-tests/test-applications/vue-3/node_modules/.pnpm/ts-node@10.9.1_@types+node@20.12.12_typescript@5.3.3/node_modules/ts-node/dist/child/child-loader.js:19:122)
at nextLoad (node:internal/modules/esm/hooks:864:28)
at Hooks.load (node:internal/modules/esm/hooks:447:26)
at MessagePort.handleMessage (node:internal/modules/esm/worker:196:24)
at [nodejs.internal.kHybridDispatch] (node:internal/event_target:786:20) {
code: 'ERR_UNKNOWN_FILE_EXTENSION'
} 😬 |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol, I also just used CJS in sveltekit2+svelte5 app because ts-node didn't play nicely with the app's tsconfig and couldn't solve it quickly. Totally fine to do this generally from my PoV 👍
Extracted this out from #12020 For whatever reason, this does not seemed to play well with how we run the proxy server via ts-node. Looking into this more, this is actually not really necessary at all, so I just stripped this out in favor of just running the proxy as a `.mjs` file directly - works just as well!
Extracted this out from #12020
For whatever reason, this does not seemed to play well with how we run the proxy server via ts-node. Looking into this more, this is actually not really necessary at all, so I just stripped this out in favor of just running the proxy as a
.mjs
file directly - works just as well!