[Dynamic Sampling] Head of trace #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
cleptric
force-pushed
the
head-of-trace
branch
from
700b21a
to
cb2671b
Compare
kamilogorek
reviewed
Nov 9, 2022
kamilogorek
reviewed
Nov 9, 2022
kamilogorek
reviewed
Nov 9, 2022
cleptric
force-pushed
the
head-of-trace
branch
from
1877d35
to
5a460e6
Compare
AbhiPrasad
reviewed
Nov 30, 2022
dynamic_sampling_context.go
Outdated
| @@ -36,10 +37,57 @@ func NewDynamicSamplingContext(header []byte) (DynamicSamplingContext, error) { | |||
| }, nil | |||
| } | |||
|
|
|||
| func DynamicSamplingContextFromTransaction(span *Span) (DynamicSamplingContext, error) { | |||
There was a problem hiding this comment.
m: Should this return an error?
Co-authored-by: Abhijeet Prasad <devabhiprasad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support in case we're the head SDK that starts the trace for Dynamic Sampling.
DynamicSamplingContextFromTransactionSpan.SourcePopulating the envelop header will be done in #491
Closes #457