Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Dynamic Sampling #491

Merged
merged 18 commits into from Dec 5, 2022
Merged

feat: Add support for Dynamic Sampling #491

merged 18 commits into from Dec 5, 2022

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Nov 7, 2022

This PR is the first episode in the series to support Dynamic Sampling in the Go SDK.

  • Parse incoming baggage headers and attach the DSC on the transaction. I vendored in the OpenTelemetry baggage implementation from https://github.com/open-telemetry/opentelemetry-go
  • Introduce SDKMetaData, a way to pass the DSC from the transaction to the event (similar to PHP & JS)
  • Extend the envelope header by adding dsn, sdk and trace

I'll use this PR as the base for the whole feature and will branch out from here for the remaining tasks.

Related PRs

Closes #456

@cleptric cleptric added this to the Dynamic Sampling Context milestone Nov 7, 2022
tracing.go Outdated Show resolved Hide resolved
tracing.go Outdated Show resolved Hide resolved
interfaces.go Outdated Show resolved Hide resolved
interfaces.go Outdated Show resolved Hide resolved
tracing.go Outdated Show resolved Hide resolved
cleptric and others added 4 commits November 9, 2022 16:50
Co-authored-by: Kamil Ogórek <kamil@sentry.io>
Co-authored-by: Abhijeet Prasad <devabhiprasad@gmail.com>
@cleptric cleptric force-pushed the dynamic-sampling branch 3 times, most recently from 33562f0 to f219a81 Compare December 5, 2022 04:16
cleptric and others added 2 commits December 5, 2022 11:11
Co-authored-by: Abhijeet Prasad <devabhiprasad@gmail.com>
@cleptric cleptric marked this pull request as ready for review December 5, 2022 10:16
@cleptric cleptric merged commit c63acf9 into master Dec 5, 2022
@cleptric cleptric deleted the dynamic-sampling branch December 5, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(tracing) [DSC] Dynamic Sampling Context continuation
4 participants