New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
flutter min version test #966
Conversation
min_version_test/android/app/src/main/kotlin/com/example/min_version_test/MainActivity.kt
Outdated
Show resolved
Hide resolved
min_version_test/android/app/src/main/kotlin/com/example/min_version_test/MainActivity.kt
Outdated
Show resolved
Hide resolved
min_version_test/android/app/src/main/kotlin/com/example/min_version_test/MainActivity.kt
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #966 +/- ##
==========================================
+ Coverage 89.51% 89.55% +0.04%
==========================================
Files 105 106 +1
Lines 3308 3322 +14
==========================================
+ Hits 2961 2975 +14
Misses 347 347
Continue to review full report at Codecov.
|
@ueman found one more issue:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
馃摐 Description
TODO: changelog
#skip-changelog
Bump Flutter to min 2.0.0
Add CI step that compiles using Flutter's min. supported version now 2.0.0 and Dart 2.12.0
Fix
hashCode
issue.Add dependency for
logging
anddio
so they are compiled against the min. version as well.馃挕 Motivation and Context
Fixes #962
Fixes #636
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps