Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back compatibility for OnErrorIntegration integration #965

Merged
merged 3 commits into from Jul 28, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jul 27, 2022

馃摐 Description

馃挕 Motivation and Context

Fix #964

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

馃敭 Next steps

#966

@marandaneto marandaneto requested a review from ueman July 27, 2022 18:12
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #965 (3983cfe) into main (aad9fc7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #965   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files         105      105           
  Lines        3308     3308           
=======================================
  Hits         2961     2961           
  Misses        347      347           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update aad9fc7...3983cfe. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 6750ca1 into main Jul 28, 2022
@marandaneto marandaneto deleted the fix/OnErrorIntegration-compat branch July 28, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I'm using Sentry 6.4.0 but from one hour I started get this error
4 participants