Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Client Reports #829

Merged
merged 15 commits into from Apr 28, 2022
Merged

Feat: Client Reports #829

merged 15 commits into from Apr 28, 2022

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Apr 13, 2022

馃摐 Description

Feature branch collecting all sub-branches for the client reports implementation.

馃挕 Motivation and Context

Closes #812

馃挌 How did you test it?

Unit tests.

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

馃敭 Next steps

  • Set sendClientReports on native Android options when Java Client Reports are merged
  • Test End-To-End on iOS, Android and Web

Closes #735

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #829 (9a906ff) into main (3af1dc8) will increase coverage by 0.37%.
The diff coverage is 96.03%.

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
+ Coverage   89.95%   90.33%   +0.37%     
==========================================
  Files         114      119       +5     
  Lines        3703     3776      +73     
==========================================
+ Hits         3331     3411      +80     
+ Misses        372      365       -7     
Impacted Files Coverage 螖
dart/lib/src/transport/rate_limit.dart 100.00% <酶> (酶)
dart/lib/src/transport/data_category.dart 72.22% <72.22%> (酶)
dart/lib/src/client_reports/client_report.dart 100.00% <100.00%> (酶)
...lib/src/client_reports/client_report_recorder.dart 100.00% <100.00%> (酶)
dart/lib/src/client_reports/discard_reason.dart 100.00% <100.00%> (酶)
dart/lib/src/client_reports/discarded_event.dart 100.00% <100.00%> (酶)
...rc/client_reports/noop_client_report_recorder.dart 100.00% <100.00%> (酶)
dart/lib/src/hub.dart 80.48% <100.00%> (+0.11%) 猬嗭笍
dart/lib/src/sentry_client.dart 94.73% <100.00%> (+0.67%) 猬嗭笍
dart/lib/src/sentry_envelope.dart 100.00% <100.00%> (酶)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3af1dc8...9a906ff. Read the comment docs.

@denrase denrase marked this pull request as ready for review April 21, 2022 07:57
@denrase denrase requested a review from brustolin as a code owner April 21, 2022 07:57
@marandaneto
Copy link
Contributor

It needs testing with the iOS and Android bridges, but codewise looks good.

Copy link
Collaborator

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@denrase
Copy link
Collaborator Author

denrase commented Apr 27, 2022

@marandaneto Client reports are being send with the HttpTransport and we get a 200 response from the backend.

Bildschirmfoto 2022-04-27 um 13 59 26

@marandaneto marandaneto merged commit da70ee1 into main Apr 28, 2022
@marandaneto marandaneto deleted the feat/client-reports branch April 28, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants