Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what's up with client reports #1432

Closed
6 tasks
chadwhitacre opened this issue Apr 26, 2022 · 9 comments
Closed
6 tasks

Figure out what's up with client reports #1432

chadwhitacre opened this issue Apr 26, 2022 · 9 comments

Comments

@chadwhitacre
Copy link
Member

chadwhitacre commented Apr 26, 2022

Client reports are a protocol feature that let clients send status reports about themselves to Sentry. They are currently mainly used to emit outcomes for events that were never sent. Chained relays are also able to emit these client reports to inform the next relay in chain about some outcomes.

Due to a bug in Relay, which discards envelopes containing unknown envelope items, the minimum required version of Sentry for client reports is 21.9.0.

https://develop.sentry.dev/sdk/client-reports/

What versions of what SDKs send client reports?

What version of Relay introduced the bug that causes us to drop envelopes containing client reports?

@chadwhitacre
Copy link
Member Author

Honestly this info should probably end up on that doc https://develop.sentry.dev/sdk/client-reports/

@marandaneto
Copy link

sentry-dart, 6.6.0 (not yet published)
sentry-java, 6.0.0 (still alpha)
sentry-cocoa, 7.13.0 (GA)

@jan-auer
Copy link
Member

What version of Relay introduced the bug that causes us to drop envelopes containing client reports?

It has always been this way, from introducing Envelopes. Relay never accepted unknown item types while it should've. This being fixed through getsentry/relay#1246

@philipphofmann
Copy link
Member

Honestly this info should probably end up on that doc https://develop.sentry.dev/sdk/client-reports/

It already is there @chadwhitacre.

@chadwhitacre
Copy link
Member Author

I meant the details about SDK versions. This would be a great use case for an automated capabilities matrix in https://github.com/getsentry/sentry-release-registry

@chadwhitacre
Copy link
Member Author

@mitsuhiko Is this the one where we talked about SDKs reporting an issue into the self-hosted instance if they detect the server version is too low? We were approaching from marketing / incentivizing upgrade angle.

@chadwhitacre chadwhitacre mentioned this issue Apr 29, 2022
6 tasks
@chadwhitacre
Copy link
Member Author

chadwhitacre commented May 16, 2022

I have a note to add something to the release notes for self-hosted about this, but I'm not sure what I'm supposed to say. I think for people upgrading to the latest self-hosted there is no action item, correct? The action item is for people who have upgraded their SDK without upgrading self-hosted (past 21.9.0), correct?

@jan-auer
Copy link
Member

The action item is for people who have upgrade their SDK without upgrading self-hosted (past 21.9.0), correct?

That is correct.

@chadwhitacre
Copy link
Member Author

Okay, I think we can close here, then. Lmk if I'm missing some action item for self-hosted.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants