feat: upload list of slow/frozen rendered frame timestamps during a profile #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Generally speaking, this PR goes in the right direction. Maybe it only makes sense to send the frames' timestamps not rendered in time. The server then could calculate the timestamps if we also send the start time of the first frame. This would reduce the payload significantly.
If we use a ring buffer for keeping track of the frame timestamps, we could already set the array to a fixed size, and we will avoid allocations for every frame.
armcknight
force-pushed
the
armcknight/gpu-frame-metrics
branch
2 times, most recently
from
a3bcf4a
to
144a68b
Compare
armcknight
changed the title
armcknight
force-pushed
the
armcknight/gpu-frame-metrics
branch
3 times, most recently
from
6cd891d
to
77cb781
Compare
armcknight
force-pushed
the
armcknight/gpu-frame-metrics
branch
from
841ba7b
to
91b136e
Compare
There was a problem hiding this comment.
With #1912 we plan on adding spans for slow and frozen frames. After finishing this PR, this is going to be easy 👌.
This PR misses some tests.
armcknight
force-pushed
the
armcknight/gpu-frame-metrics
branch
from
a598777
to
d26e282
Compare
|
Sorry, @armcknight didn't get to this today. Will do it tomorrow. |
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
armcknight
force-pushed
the
armcknight/gpu-frame-metrics
branch
from
61ddb40
to
d2dfd83
Compare
…hInternal; move early bail for hub nil check earlier
Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
kevinrenskers
added a commit
that referenced
this pull request
Jul 14, 2022
* master: ci: Don't run benchmarks on release (#1971) Don't track OOMs for simulators (#1970) feat: Automatic nest new spans with the ui life cycle function (#1959) docs: update some docs/comments to read a little better (#1966) ci: benchmarking updates (#1926) feat: upload list of slow/frozen rendered frame timestamps during a profile (#1910) feat: Enhance the UIViewController breadcrumbs with more data (#1945) # Conflicts: # Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_System.h
kevinrenskers
added a commit
that referenced
this pull request
Jul 18, 2022
* master: ref: Fix linter error (#1981) fix: read free_memory when the event is captured, not only at SDK startup (#1962) fix: Remove Sentry keys from cached HTTP request headers (#1975) release: 7.21.0 ci: Don't run benchmarks on release (#1971) Don't track OOMs for simulators (#1970) feat: Automatic nest new spans with the ui life cycle function (#1959) docs: update some docs/comments to read a little better (#1966) ci: benchmarking updates (#1926) feat: upload list of slow/frozen rendered frame timestamps during a profile (#1910)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Upload the start and end timestamp for each frame that is rendered while a transaction is being traced with profiling enabled.
💡 Motivation and Context
In order to help diagnose why an app may be experiencing janky frames, it would be helpful to be able to drill down into sampled backtraces in the web dashboard profiling area that corresponds to frames that take too long to render.
💚 How did you test it?
So far, just confirming that the data is uploaded by inspecting the app state in the debugging after manually working in the iOS-Swift sample app.
📝 Checklist
🔮 Next steps