Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upload list of slow/frozen rendered frame timestamps during a profile #1910

Merged
merged 43 commits into from
Jul 13, 2022
Merged

feat: upload list of slow/frozen rendered frame timestamps during a profile #1910

merged 43 commits into from
Jul 13, 2022

Commits on Jul 12, 2022

  1. feat: upload list of all rendered frame timestamps during a profile

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    e209a56 View commit details
    Browse the repository at this point in the history

  2. docs: update changelog

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    5abf281 View commit details
    Browse the repository at this point in the history

  3. Format code

    @getsentry-bot @armcknight
    getsentry-bot authored and armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    bbe4255 View commit details
    Browse the repository at this point in the history

  4. fix: PR feedback; conditionally compile more stuff only for profiling

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    cdd764b View commit details
    Browse the repository at this point in the history

  5. fix: unlock profiler after querying if it's running

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    7c40ab3 View commit details
    Browse the repository at this point in the history

  6. fix: bad conflict resolution

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    df4b44d View commit details
    Browse the repository at this point in the history

  7. fix: use a ring buffer to place an upper bound on the amount of times… 

    …tamps recorded
    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    4bf5c7c View commit details
    Browse the repository at this point in the history

  8. Format code

    @getsentry-bot @armcknight
    getsentry-bot authored and armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    8da1ed8 View commit details
    Browse the repository at this point in the history

  9. fix: don't advance previousFrameTimestamp until after recording for p… 

    …rofiling
    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    f6bd805 View commit details
    Browse the repository at this point in the history

  10. Format code

    @getsentry-bot @armcknight
    getsentry-bot authored and armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    796d38d View commit details
    Browse the repository at this point in the history

  11. fix: bad conflict resolution

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    5faee87 View commit details
    Browse the repository at this point in the history

  12. fix: compile fix for platforms without uikit

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    6bb11a1 View commit details
    Browse the repository at this point in the history

  13. Format code

    @getsentry-bot @armcknight
    getsentry-bot authored and armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    872e983 View commit details
    Browse the repository at this point in the history

  14. fix: conditional compilation for other platforms not using profiling

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    5283d8d View commit details
    Browse the repository at this point in the history

  15. Format code

    @getsentry-bot @armcknight
    getsentry-bot authored and armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    41e434e View commit details
    Browse the repository at this point in the history

  16. fix: changelog after bad merge

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    bc82892 View commit details
    Browse the repository at this point in the history

  17. fix: only init timestamp array if profiling

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    8bb9d28 View commit details
    Browse the repository at this point in the history

  18. Format code

    @getsentry-bot @armcknight
    getsentry-bot authored and armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    758ee4e View commit details
    Browse the repository at this point in the history

  19. fix: use a ring buffer to place an upper bound on the amount of times… 

    …tamps recorded
    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    3d5223a View commit details
    Browse the repository at this point in the history

  20. fix: changelog after bad merge

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    84cfe76 View commit details
    Browse the repository at this point in the history

  21. fix: reset timestamps for each profiled transaction

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    f29aa9d View commit details
    Browse the repository at this point in the history

  22. fix: convert timestamps to be relative to transaction start in nanose… 

    …conds
    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    52e3177 View commit details
    Browse the repository at this point in the history

  23. fix: revert to plain array instead of ringbuffer

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    d00d45c View commit details
    Browse the repository at this point in the history

  24. ref: also send time series of refresh rate changes during profiled tr… 

    …ansactions
    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    11c8cdf View commit details
    Browse the repository at this point in the history

  25. Format code

    @getsentry-bot @armcknight
    getsentry-bot authored and armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    03d41ad View commit details
    Browse the repository at this point in the history

  26. fix: compilation without UIKit

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    0ea16a0 View commit details
    Browse the repository at this point in the history

  27. Format code

    @getsentry-bot @armcknight
    getsentry-bot authored and armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    08624b9 View commit details
    Browse the repository at this point in the history

  28. fix: bad conflict resolution

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    b4b3be9 View commit details
    Browse the repository at this point in the history

  29. fix: properly set refresh rate relative timestamps

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    0fee73e View commit details
    Browse the repository at this point in the history

  30. docs: fix changelog after bad merge

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    c5c4899 View commit details
    Browse the repository at this point in the history

  31. fix: pr feedback around proper state management of frame tracker for … 

    …profiling
    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    643eb5a View commit details
    Browse the repository at this point in the history

  32. Format code

    @getsentry-bot @armcknight
    getsentry-bot authored and armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    2a60e11 View commit details
    Browse the repository at this point in the history

  33. Update Sources/Sentry/SentryFramesTracker.m 

    Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
    @armcknight @philipphofmann
    armcknight and philipphofmann committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    480c869 View commit details
    Browse the repository at this point in the history

  34. Update Sources/Sentry/SentryFramesTracker.m 

    Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
    @armcknight @philipphofmann
    armcknight and philipphofmann committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    bf9fc96 View commit details
    Browse the repository at this point in the history

  35. fix: more renames

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    035a578 View commit details
    Browse the repository at this point in the history

  36. fix: non-ios builds

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    d2dfd83 View commit details
    Browse the repository at this point in the history

  37. Format code

    @getsentry-bot
    getsentry-bot committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    75fefa3 View commit details
    Browse the repository at this point in the history

  38. ref: move all possible logic to first locked profiler sector in finis… 

    …hInternal; move early bail for hub nil check earlier
    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    4a44bf3 View commit details
    Browse the repository at this point in the history

  39. Format code

    @getsentry-bot
    getsentry-bot committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    0cf376a View commit details
    Browse the repository at this point in the history

  40. Update Sources/Sentry/Public/SentryScreenFrames.h 

    Co-authored-by: Philipp Hofmann <philipp.hofmann@sentry.io>
    @armcknight @philipphofmann
    armcknight and philipphofmann committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    9a1f77a View commit details
    Browse the repository at this point in the history

  41. docs: fix changelog after bad merge

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    ed687fd View commit details
    Browse the repository at this point in the history

  42. fix: allow null

    @armcknight
    armcknight committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    25b8904 View commit details
    Browse the repository at this point in the history

  43. Format code

    @getsentry-bot
    getsentry-bot committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    f020c7e View commit details
    Browse the repository at this point in the history