Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prebuilt 34 #231

Merged
merged 2 commits into from Jan 3, 2022
Merged

Prebuilt 34 #231

merged 2 commits into from Jan 3, 2022

Conversation

geohardtke
Copy link
Contributor

@geohardtke geohardtke commented Nov 13, 2021 •
edited

Hi there,
I'd like to contribute the pre built bindings for the new 3.4 version of GDAL.

@pka pka mentioned this pull request Dec 2, 2021
Open
2 tasks
@lnicola
Copy link
Member

lnicola commented Jan 2, 2022

I'd like to merge this tomorrow unless anyone objects.

@jdroenner
Copy link
Member

yes please merge it :)

@jdroenner jdroenner mentioned this pull request Jan 3, 2022
Merged
@lnicola
Copy link
Member

lnicola commented Jan 3, 2022

bors r+

bors bot added a commit that referenced this pull request Jan 3, 2022
@bors @geohardtke
Merge #231
f7790d3 
231: Prebuilt 34 r=lnicola a=geohardtke

Hi there,
I'd like to contribute the pre built bindings for the new 3.4 version of GDAL. 

Co-authored-by: Leonardo Hardtke <leonardo.hardtke@des.qld.gov.au>
@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Build failed:

@jdroenner
Copy link
Member

i guess we have to adapt these tests first

@lnicola
Copy link
Member

lnicola commented Jan 3, 2022

Is anyone opposed to dropping the trybuild thing? It very fragile, especially when trying to support multiple compiler versions, because the error messages sometimes change.

@jdroenner
Copy link
Member

there is already a discussion here: #234
i'm not against dropping it if we can't make it work

@lnicola lnicola mentioned this pull request Jan 3, 2022
Closed
2 tasks
@jdroenner
Copy link
Member

now we have both options #237

@jdroenner
Copy link
Member

we should first try to adapt the test. if it is not maintainable,, e.g. if it fails again ext week, then we can drop it.

@lnicola
Copy link
Member

lnicola commented Jan 3, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

Build succeeded:

@bors bors bot merged commit 00adecc into georust:master Jan 3, 2022
@jdroenner jdroenner mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geohardtke @lnicola @jdroenner