Drop the compile-fail test #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a single `trybuild` test but it's very fragile because the error messages tend to change. Since there's no multi-baseline support in `trybuild`, this makes supporting multiple compiler versions impossible.
|
bors try |
|
r? @jdroenner |
tryMerge conflict. |
bors bot
added a commit
that referenced
this pull request
Oct 31, 2022
329: Drop `trybuild` test r=jdroenner a=lnicola - [x] I agree to follow the project's [code of conduct](https://github.com/georust/gdal/blob/master/CODE_OF_CONDUCT.md). - [ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users. --- Follow-up to #236 Closes #312 `trybuild` sounds nice, however: - it doesn't work (out of the box) with multiple compiler versions, so it breaks when upgrading compilers: #234 - when testing with `--all-features`, it causes the code to be rebuilt twice - I've seen it give some weird errors in unusual circumstances (under `gdb`, maybe?) - it's completely broken for `@metasim` (#312), but not on CI, see also #312 (comment) - 1.5 years later, we still only have one test Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a single
trybuildtest but it's very fragile because theerror messages tend to change. Since there's no multi-baseline
support in
trybuild, this makes supporting multiple compilerversions impossible.
CHANGES.mdif knowledge of this change could be valuable to users.CC #231