Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: fix point creation in clip test suite #2623

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

martinfleis
Copy link
Member

This should fix the failures on CI in an env with shapely 2.0b2. shapely/shapely#1590 uncovered that we were passing a list of tuples to a Point constructor. While old shapely uses only the first tuple and ignores the rest, shapely 2.0b2 correctly raises an error.

Copy link
Member

@m-richards m-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Docstrings on these fixtures are a bit misleading but that doesn't need to be fixed here.

@martinfleis martinfleis merged commit e50201b into geopandas:main Nov 1, 2022
@martinfleis martinfleis deleted the point_sh2 branch November 1, 2022 11:18
@m-richards
Copy link
Member

(From Martin's comment in the linked shapely issue)

GeoPandas CI fails on this
Point([(2, 3), (11, 4), (7, 2), (8, 9), (1, 13)])
Which I'd say is a correct behaviour. I don't really understand what is the intention of this line.

Just doing some archeology on this,
seems to have been introduced here:
lwasser@67c58c0#diff-999030931f6802617e56e4c04679840188538ca61816e9ee97d9fac0763563dc
and then copied through into the analogous test for geometrycollections. Seems fairly likely that the intent was to actually add a point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants