New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): correct pagination logic #32496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jul 23, 2021
vladar
added
topic: GraphQL
Related to Gatsby's GraphQL layer
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Jul 23, 2021
Closed
2 tasks
pieh
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 it
vladar
added
the
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
label
Jul 23, 2021
LekoArts
pushed a commit
that referenced
this pull request
Jul 26, 2021
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: merge on green
Gatsbot will merge these PRs automatically when all tests passes
topic: GraphQL
Related to Gatsby's GraphQL layer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with incorrect pagination logic introduced in a recent refactor: #32135
The previous attempt in #32319 in fact contains incorrect assumptions about pagination logic. The actual issue was not in
paginate
function itself but one level higher in the method that accounts for item paddings.This PR fixes the issue and adds tests at the correct level of abstraction. The first commit is just a revert of #32319 so the actual fix is in the second commit (for the review): 1d19c08
Fixes #32485
[ch35018]