Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql pageInfo.hasNextPage did not work properly after upgrade packages to latest version #32485

Closed
2 tasks done
hgb123 opened this issue Jul 22, 2021 · 2 comments · Fixed by #32496
Closed
2 tasks done
Labels
topic: GraphQL Related to Gatsby's GraphQL layer type: bug An issue or pull request relating to a bug in Gatsby

Comments

@hgb123
Copy link

hgb123 commented Jul 22, 2021

Preliminary Checks

Description

I upgraded all package version to the latest (information below) and the pagination feature broke due to the unexpected value on pageInfo.hasNextValue

Page 1, Next button is enabled ✅
image

Page 2, Next button is disabled ❌
image

Page 3, Next button is disabled ❌
image

Reproduction Link

https://github.com/hgb123/gatsby-issue-reproduce

Steps to Reproduce

  1. Install packages yarn
  2. Run local dev yarn start
  3. Open localhost:8000
  4. Click Next button

Expected Result

pageInfo.hasNextPage should be true on page 1-3/4

Actual Result

pageInfo.hasNextPage was false on page 2/4, 3/4

Environment

System:
    OS: Windows 10 10.0.19042
    CPU: (8) x64 Intel(R) Core(TM) i7-4810MQ CPU @ 2.80GHz
  Binaries:
    Node: 14.17.0 - D:\Harrogath\nodejs\node.EXE
    Yarn: 1.22.10 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 7.18.1 - D:\Harrogath\nodejs\npm.CMD
  Languages:
    Python: 3.8.5
  Browsers:
    Chrome: 91.0.4472.164
    Edge: Spartan (44.19041.1023.0), Chromium (91.0.864.71)
  npmPackages:
    gatsby: 3.10.1 => 3.10.1 
    gatsby-source-filesystem: 3.10.0 => 3.10.0 
    gatsby-transformer-remark: ^4.7.0 => 4.7.0 
  npmGlobalPackages:
    gatsby-cli: 3.4.1

Config Flags

No response

@hgb123 hgb123 added the type: bug An issue or pull request relating to a bug in Gatsby label Jul 22, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 22, 2021
@vladar vladar added topic: GraphQL Related to Gatsby's GraphQL layer and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 23, 2021
@vladar
Copy link
Contributor

vladar commented Jul 23, 2021

Thank you for the report and the great repro! Should be hopefully fixed in #32496

@LekoArts
Copy link
Contributor

Fixed in gatsby@3.10.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: GraphQL Related to Gatsby's GraphQL layer type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants