fix(gatsby): garbage collect stateful pages #28760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: state machine
and removed
status: triage needed
pieh
force-pushed
the
garbage-collect-stateful-pages
branch
from
21a87f9
to
29ba318
Compare
pieh
force-pushed
the
fix/no-rebuild-bug
branch
from
eb6689b
to
619041c
Compare
pieh
force-pushed
the
garbage-collect-stateful-pages
branch
3 times, most recently
from
a8f9932
to
eab599b
Compare
pieh
force-pushed
the
garbage-collect-stateful-pages
branch
from
a3d8fde
to
60dd715
Compare
pieh
added a commit
that referenced
this pull request
Apr 22, 2021
* fix(gatsby): add pages to saved redux state * chore: update test snapshots * unskip context change scenario for data tracking tests * mock Date.now so persistance tests don't rely on actual time (needed for updatedAt and snapshot testing) * refactor persistance tests a bit to allow for creating different pages per test scenario * shard pages state (on top of existing sharding for nodes) * drop page count check (there actually might be valid cases for 0 pages) * only show page context size warning for pages (and not nodes) * fix lint * adjust snapshot * test(artifacts): add case for changing page context * fix(gatsby): garbage collect stateful pages (#28760) * add stateful page to artifacts tests * fix(gatsby): garbage collect stateful pages * Revert "fix: clear tracked queries when deleting stale page-data files (#29431)" (#30848) This reverts commit 478cf68. Co-authored-by: Reda Bacha <mohamedredabacha@hollandandbarrett.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #28590
This is needed for when
pagesare being persisted to clean up stateful pages from previous runs that are not being recreated (there's plenty of state reducers that relies onDELETE_PAGE/CREATE_PAGEbeing emitted - includingqueriesreducer).This PR targets specifically this comment - #28590 (comment)
Opened as separate PR to be easier to review this distinct change.
Related Issues
#28590