fix: clear tracked queries when deleting stale page-data files #29431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
commented
Feb 10, 2021
| if (!expectedPageDataFiles.has(pageDataFilePath)) { | ||
| const stalePageDataContent = await fs.readJson(pageDataFilePath) |
There was a problem hiding this comment.
this adds fs operation - but just for page-data files that are marked as stale and scheduled for deletion. This is to grab page.path.
Alternatively we could try to derive page.path from location of page-data file, but this is not deterministic due to all the variations of leading and trailing slashes ... and it also would be more convoluted.
There was a problem hiding this comment.
A nice trick to get this path! 😄
pieh
added
topic: stale-artifacts*
and removed
status: triage needed
ghost
previously approved these changes
Feb 10, 2021
|
Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page. Generated by 🚫 dangerJS |
vladar
approved these changes
Feb 10, 2021
1 task
pieh
added a commit
that referenced
this pull request
Apr 21, 2021
pieh
added a commit
that referenced
this pull request
Apr 22, 2021
* fix(gatsby): add pages to saved redux state * chore: update test snapshots * unskip context change scenario for data tracking tests * mock Date.now so persistance tests don't rely on actual time (needed for updatedAt and snapshot testing) * refactor persistance tests a bit to allow for creating different pages per test scenario * shard pages state (on top of existing sharding for nodes) * drop page count check (there actually might be valid cases for 0 pages) * only show page context size warning for pages (and not nodes) * fix lint * adjust snapshot * test(artifacts): add case for changing page context * fix(gatsby): garbage collect stateful pages (#28760) * add stateful page to artifacts tests * fix(gatsby): garbage collect stateful pages * Revert "fix: clear tracked queries when deleting stale page-data files (#29431)" (#30848) This reverts commit 478cf68. Co-authored-by: Reda Bacha <mohamedredabacha@hollandandbarrett.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deleting stale page-data files from previous builds doesn't clean up our query tracking state. This can result in following kind of errors at SSG step:
It can be reproduced by conditionally adding/removing page between builds where we wouldn't clear cache in between runs:
queriesreducer will still keep track of itNote - this is more of a hot fix. Proper fix #28590 and #28760 (as in persisting pages to be able to rely on already existing
DELETE_PAGEaction handler inqueriesreducer (which just doesn't happen right now because pages are not persisted)