Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ready check for Webhook server #421

Merged
merged 3 commits into from
Mar 30, 2022
Merged

Add ready check for Webhook server #421

merged 3 commits into from
Mar 30, 2022

Conversation

acumino
Copy link
Member

@acumino acumino commented Mar 21, 2022

How to categorize this PR?

/area open-source
/kind enhancement
/platform openstack

What this PR does / why we need it:
The PR adds ready check for webhook server. The ready check wait for 10 sec for webhook server to be ready, otherwise throws error.

Which issue(s) this PR fixes:
Part of gardener/gardener#4772

Special notes for your reviewer:

Release note:

NONE

@acumino acumino requested review from a team as code owners March 21, 2022 11:38
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure labels Mar 21, 2022
@gardener-robot
Copy link

@acumino Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 21, 2022
@acumino
Copy link
Member Author

acumino commented Mar 21, 2022

/invite @rfranzke @timebertt

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 21, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 22, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 22, 2022
@acumino
Copy link
Member Author

acumino commented Mar 22, 2022

/milestone v1.25

@acumino acumino added this to the v1.25 milestone Mar 22, 2022
@gardener-robot
Copy link

@rfranzke You have pull request review open invite, please check

dkistner
dkistner previously approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2022
@acumino acumino requested a review from dkistner March 25, 2022 14:46
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2022
dkistner
dkistner previously approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 28, 2022
@dkistner
Copy link
Member

/rebase

@gardener-robot gardener-robot added needs/rebase Needs git rebase and removed reviewed/lgtm Has approval for merging labels Mar 28, 2022
@gardener-robot gardener-robot added the needs/review Needs review label Mar 28, 2022
@acumino acumino requested a review from dkistner March 28, 2022 08:40
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 28, 2022
This was referenced Mar 30, 2022
Merged
Merged
dkistner
dkistner approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dkistner dkistner merged commit 756cd4b into gardener:master Mar 30, 2022
@acumino acumino mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

@rfranzke rfranzke Awaiting requested review from rfranzke

@timebertt timebertt Awaiting requested review from timebertt

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review platform/openstack OpenStack platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@acumino @gardener-robot @dkistner @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3