This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Add ready check for webhook server #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
acumino
added
area/open-source
gardener-robot
added
reviewed/lgtm
briantopping
suggested changes
Apr 4, 2022
| @@ -46,6 +46,19 @@ spec: | |||
| {{- if .Values.global.kubeconfig }} | |||
| - --kubeconfig=/etc/gardener-extension-validator-vsphere/kubeconfig/kubeconfig | |||
| {{- end }} | |||
| - --health-bind-address=:{{ .Values.global.healthPort }} | |||
There was a problem hiding this comment.
It makes sense to wrap this in case the values are not provided, see https://github.com/gardener/gardener/blob/e8e73842ad0acfe30c02eb7d17c8c7b2fd42a4e5/charts/gardener/gardener-resource-manager/templates/deployment.yaml#L62-L64
There was a problem hiding this comment.
It was suggested here not to add if gardener/gardener-extension-provider-openstack#421 (comment)
| @@ -44,6 +44,7 @@ spec: | |||
| - --webhook-config-server-port={{ .Values.webhookConfig.serverPort }} | |||
| - --disable-controllers={{ .Values.disableControllers | join "," }} | |||
| - --disable-webhooks={{ .Values.disableWebhooks | join "," }} | |||
| - --health-bind-address=:{{ .Values.healthPort }} | |||
There was a problem hiding this comment.
It makes sense to wrap this in case the values are not provided, see https://github.com/gardener/gardener/blob/e8e73842ad0acfe30c02eb7d17c8c7b2fd42a4e5/charts/gardener/gardener-resource-manager/templates/deployment.yaml#L62-L64
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind enhancement
/platform vsphere
What this PR does / why we need it:
The PR adds ready check for webhook server. The ready check wait for 10 sec for webhook server to be ready, otherwise throws error.
Which issue(s) this PR fixes:
Part of gardener/gardener#4772
Special notes for your reviewer:
Release note: