Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #72 switch from eslint-plugin-node to eslint-plugin-n #75

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Resolves #72 switch from eslint-plugin-node to eslint-plugin-n #75

merged 3 commits into from
Nov 14, 2023

Conversation

beuluis
Copy link
Contributor

@beuluis beuluis commented Oct 30, 2023

Resolves #72
Replace eslint-plugin-node with eslint-plugin-n as the old one is not maintained anymore: mysticatea/eslint-plugin-node#300

@beuluis
Copy link
Contributor Author

beuluis commented Nov 13, 2023

Hey there @gajus,

did you have time to take a look?

Should i provide it via a different process?

Let me know what i can do to get this merged🙂

Thanks!

@beuluis
Copy link
Contributor Author

beuluis commented Nov 13, 2023

Sorry @gajus my bad. Fixed the misconfigured npmrc on my side :)

@beuluis
Copy link
Contributor Author

beuluis commented Nov 14, 2023

@gajus I fixed all i could find.

But I noticed that the find-deprecated script is broken due to a usage of the ES Module got.

Investigated but this was already introduced 8 months ago. So i did not touch it to separate it from those changes here.

@gajus
Copy link
Owner

gajus commented Nov 14, 2023

Thank you!

@gajus gajus merged commit ca45625 into gajus:main Nov 14, 2023
1 check passed
Copy link

🎉 This PR is included in version 42.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@beuluis beuluis mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-plugin-node seems to be deprecated or not maintained
2 participants