Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken lock file #77

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

beuluis
Copy link
Contributor

@beuluis beuluis commented Nov 16, 2023

@gajus I am so so sorry but i just realised that i missed a bit in #75 where my private registry got mixed in and it got merged to main

I did not see that it also happened in /compare.

So here is the correction. Sorry for the trouble!

Would maybe be nice if you add a npm ci also for this package.json in the actions as a test step to be save in the future.

So so sorry again! Have a nice evening

@beuluis
Copy link
Contributor Author

beuluis commented Nov 16, 2023

You can also merge only: #76 and close this since it also contains those fixes. But I also provided them here separately if you decide to not merge my other changes or need more time to review them

@gajus gajus merged commit 5e5dd8c into gajus:main Nov 16, 2023
1 check passed
Copy link

🎉 This PR is included in version 42.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants