Small changes to prep for caching daemon #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 5, 2024
Merged
airhorns
changed the title
airhorns
force-pushed
the
harry/multi-stage-docker
branch
from
42a6646
to
da16b06
Compare
angelini
reviewed
May 6, 2024
| make build | ||
| ``` | ||
|
|
||
| ### Run migrations |
There was a problem hiding this comment.
Is this section supposed to have make migrate instructions?
angelini
reviewed
May 6, 2024
test/client_get_cache_test.go
Outdated
| @@ -49,7 +49,7 @@ func TestClientGetCache(t *testing.T) { | |||
| tmpCacheDir, err := os.MkdirTemp("", "dl_cache_test_tmp") | |||
| require.NoError(t, err) | |||
|
|
|||
| version, err := c.GetCache(tc.Context(), tmpCacheDir) | |||
| version, _, err := c.GetCache(tc.Context(), tmpCacheDir) | |||
There was a problem hiding this comment.
Not a bad idea to add a couple assertions on this value to make sure it's returning what we expect.
angelini
reviewed
May 6, 2024
| keys = append(keys, key) | ||
| } | ||
|
|
||
| sort.Strings(keys) |
There was a problem hiding this comment.
Damn, this was kind of a consequence of two things:
- Reproducing
packObjectsas a test util instead of using the same function we do in prod - The fact that the prod version of
packObjectsexpects a sorted stream and we use amapfor convenience in tests
The prod sorting happens here: https://github.com/gadget-inc/dateilager/blob/main/internal/db/tar.go#L233
angelini
approved these changes
May 6, 2024
airhorns
force-pushed
the
harry/multi-stage-docker
branch
from
da16b06
to
f0fc487
Compare
|
FYI, I'm going to push commits to this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetCachepackObjectstest helper produces deterministic hashes by iterating in sorted order