Add GetCache counter tests

gadget-inc · May 8, 2024 · 7e4b71a · 7e4b71a
1 parent a80bfcd
commit 7e4b71a
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/test/client_get_cache_test.go b/test/client_get_cache_test.go
@@ -49,9 +49,10 @@ func TestClientGetCache(t *testing.T) {
 	tmpCacheDir, err := os.MkdirTemp("", "dl_cache_test_tmp")
 	require.NoError(t, err)
 
-	version, _, err := c.GetCache(tc.Context(), tmpCacheDir)
+	version, count, err := c.GetCache(tc.Context(), tmpCacheDir)
 	require.NoError(t, err, "client.GetCache after GetCache")
 	assert.Equal(t, []string{"objects", "versions"}, dirFileNames(t, tmpCacheDir))
+	assert.Equal(t, uint32(4), count)
 
 	names, err := filepath.Glob(filepath.Join(tmpCacheDir, "objects/*/node_modules/*"))
 	require.NoError(t, err)
@@ -105,14 +106,16 @@ func TestClientCanHaveMultipleCacheVersions(t *testing.T) {
 	tmpCacheDir, err := os.MkdirTemp("", "dl_cache_test_tmp")
 	require.NoError(t, err)
 
-	version1, _, err := c.GetCache(tc.Context(), tmpCacheDir)
+	version1, count, err := c.GetCache(tc.Context(), tmpCacheDir)
 	require.NoError(t, err, "client.GetCache after GetCache")
+	assert.Equal(t, uint32(2), count)
 
 	_, err = db.CreateCache(tc.Context(), tc.Connect(), "pack/", 100)
 	require.NoError(t, err)
 
-	version2, _, err := c.GetCache(tc.Context(), tmpCacheDir)
+	version2, count, err := c.GetCache(tc.Context(), tmpCacheDir)
 	require.NoError(t, err, "client.GetCache after GetCache")
+	assert.Equal(t, uint32(0), count)
 
 	versionsFileContent, err := os.ReadFile(filepath.Join(tmpCacheDir, "versions"))
 	require.NoError(t, err)
@@ -134,10 +137,13 @@ func TestDownloadingTheSameVersionTwice(t *testing.T) {
 	tmpCacheDir, err := os.MkdirTemp("", "dl_cache_test_tmp")
 	require.NoError(t, err)
 
-	version1, _, err := c.GetCache(tc.Context(), tmpCacheDir)
+	version1, count, err := c.GetCache(tc.Context(), tmpCacheDir)
 	require.NoError(t, err, "client.GetCache after GetCache")
-	_, _, err = c.GetCache(tc.Context(), tmpCacheDir)
+	assert.Equal(t, uint32(2), count)
+
+	_, count, err = c.GetCache(tc.Context(), tmpCacheDir)
 	require.NoError(t, err, "client.GetCache after GetCache")
+	assert.Equal(t, uint32(0), count)
 
 	versionsFileContent, err := os.ReadFile(filepath.Join(tmpCacheDir, "versions"))
 	require.NoError(t, err)