Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Linux/XDG default theme selection #3561

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Update Linux/XDG default theme selection #3561

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d935b4f
Update Linux/XDG default theme selection
lucor Jan 12, 2023
0dffef9
defautl to light theme to support Gnome's default
lucor Jan 14, 2023
dc02990
update to follow PR suggestions
lucor Jan 14, 2023
9bcee24
Revert "update to follow PR suggestions"
lucor Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions app/app_xdg.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,19 @@ func findFreedestktopColorScheme() fyne.ThemeVariant {
return theme.VariantDark
}

// See: https://github.com/flatpak/xdg-desktop-portal/blob/1.16.0/data/org.freedesktop.impl.portal.Settings.xml#L32-L46
// 0: No preference
// 1: Prefer dark appearance
// 2: Prefer light appearance
switch value {
Jacalz marked this conversation as resolved.
Show resolved Hide resolved
case 0:
case 2:
return theme.VariantLight
default:
case 1:
return theme.VariantDark
default:
// Default to light theme to support Gnome's default see https://github.com/fyne-io/fyne/pull/3561
return theme.VariantLight
}

}

func (a *fyneApp) SendNotification(n *fyne.Notification) {
Expand Down