New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Linux/XDG default theme selection #3561
Conversation
This commit update the Linux/XDG default theme selection as per https://github.com/flatpak/xdg-desktop-portal/blob/1.16.0/data/org.freedesktop.impl.portal.Settings.xml#L32-L46 Relates to: #2657 #3414
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that the previous behavior was doing the right thing (or Gnome is not following the protocol correctly) because this change makes the switch between dark/light not work anymore for me.
I would suggest that we use light theme for both 0 and 2 instead.
But previously dark was our default if nothing was specified outside of this lookup... |
Yes, but what's the point of having this theme switching support if it isn't possible to switch between light and dark? With this change, the application is always dark no matter what you do. We have already passed the stage where we know that the desktop supports the protocol so those that do not will still default to dark. |
Thanks for getting a good solution to this one |
This reverts commit dc02990.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description:
This commit update the Linux/XDG default theme selection as per https://github.com/flatpak/xdg-desktop-portal/blob/1.16.0/data/org.freedesktop.impl.portal.Settings.xml#L32-L46
Relates to: #2657 #3414
Checklist: