Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linux/XDG default theme selection #3561

Merged
merged 4 commits into from Jan 15, 2023
Merged

Update Linux/XDG default theme selection #3561

merged 4 commits into from Jan 15, 2023

Conversation

lucor
Copy link
Member

@lucor lucor commented Jan 12, 2023

Description:

This commit update the Linux/XDG default theme selection as per https://github.com/flatpak/xdg-desktop-portal/blob/1.16.0/data/org.freedesktop.impl.portal.Settings.xml#L32-L46

Relates to: #2657 #3414

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Jan 12, 2023

Coverage Status

Coverage: 61.768% (-0.06%) from 61.824% when pulling 9bcee24 on lucor:xdg-default-theme-selection into fe77710 on fyne-io:develop.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that the previous behavior was doing the right thing (or Gnome is not following the protocol correctly) because this change makes the switch between dark/light not work anymore for me.

I would suggest that we use light theme for both 0 and 2 instead.

@andydotxyz
Copy link
Member

But previously dark was our default if nothing was specified outside of this lookup...

@Jacalz
Copy link
Member

Jacalz commented Jan 13, 2023

But previously dark was our default if nothing was specified outside of this lookup...

Yes, but what's the point of having this theme switching support if it isn't possible to switch between light and dark? With this change, the application is always dark no matter what you do.

We have already passed the stage where we know that the desktop supports the protocol so those that do not will still default to dark.

app/app_xdg.go Outdated Show resolved Hide resolved
@andydotxyz
Copy link
Member

Thanks for getting a good solution to this one

andydotxyz
andydotxyz previously approved these changes Jan 14, 2023
app/app_xdg.go Show resolved Hide resolved
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lucor lucor merged commit f1db0b5 into fyne-io:develop Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants