fix race condition in a integration test #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the CI failure in #233 |
nhooyr
changed the title
nhooyr
changed the title
|
Something is wrong with CI hmm. |
gdey
reviewed
Aug 30, 2018
| @@ -444,7 +444,7 @@ func TestFsnotifyDeleteWatchedDir(t *testing.T) { | |||
| // Receive errors on the error channel on a separate goroutine | |||
| go func() { | |||
| for err := range watcher.Errors { | |||
| t.Fatalf("error received: %s", err) | |||
| t.Error("error received: %s", err) | |||
There was a problem hiding this comment.
This should be t.Errorf("error received: %s",err)
gdey
added a commit
that referenced
this pull request
Aug 30, 2018
The documentation for t.FailNow (which is called by t.Fatalf) states that it should not be called in go routines outside of the test go routine.
nathany
pushed a commit
that referenced
this pull request
Aug 30, 2018
radu-munteanu
pushed a commit
to radu-munteanu/fsnotify
that referenced
this pull request
Feb 25, 2019
The documentation for t.FailNow (which is called by t.Fatalf) states that it should not be called in go routines outside of the test go routine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FatalF must not be called from outside the testing goroutine or this leads to a race condition within the testing package.
See https://golang.org/pkg/testing/#T.FailNow