Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink regression in v1.5.0 #390

Closed
bep opened this issue Aug 23, 2021 · 6 comments
Closed

Symlink regression in v1.5.0 #390

bep opened this issue Aug 23, 2021 · 6 comments

Comments

@bep
Copy link
Member

bep commented Aug 23, 2021

See gohugoio/hugo#8920

On Linux.

/cc @pamubay

@nathany
Copy link
Contributor

nathany commented Aug 23, 2021

Thanks for the report.

@Code0x58 Are you willing to look into this?

Reference to changes made: #289

@nathany
Copy link
Contributor

nathany commented Aug 24, 2021

There appear to be quite a number of regressions in v1.5.0 in addition to this one: #393 #389.

Thinking we may need to rollback the changes for now -- so we can take our time on giving it another try.

/cc @Code0x58 @nshalman

@nshalman
Copy link
Contributor

nshalman commented Aug 24, 2021

Thinking we may need to rollback the changes for now -- so we can take our time on giving it another try.

I support that.

@nathany
Copy link
Contributor

nathany commented Aug 24, 2021

v1.5.1 reverts the changes from 1.5.0, but lets leave this open to review.

@mterwill
Copy link

👋 any plans to revisit adding support for watching symlinks without following? Thanks!

@arp242
Copy link
Member

arp242 commented Oct 13, 2022

any plans to revisit adding support for watching symlinks without following? Thanks!

This can't be easily changed without breaking compatibility. The current situation is unfortunate because the behaviour is inconsistent on different platforms, but clearly people rely on it so it can't "just" be changed. The current API also doesn't give us much room for adding options to Add() or some such, so idk...

Either way, this is a duplicate of #227, so closing it.

@arp242 arp242 closed this as completed Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants