Remove retract directive
#400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `retract` directive only works Go >= 1.16. The versions under that can't recognize the directive and cause an error. (e.g. https://github.com/fsnotify/fsnotify/runs/3414923756) So removed the directive to work builds.
|
The latest version of Go is 1.17.5, and supported versions of Go are 1.17.5 and 1.16.12. Go 1.15 and older are already unsupported. |
|
@y-yagi Thanks for bringing this up, but I agree with @shogo82148 -- we should only need to support just the last 2 versions of Go. Also, fsnotify 1.5.0 had a number of regressions, so I think it's important to prevent people from using it. |
arp242
added a commit
that referenced
this pull request
Feb 9, 2023
I have no idea if anyone is using Go 1.16 with fsnotify. Go 1.16 (released August 2021) became mandatory with v1.5.1 (August 2021). Go 1.17 was released just a few days before it was tagged. Some people did experience problems (#400), but overall the feedback was limited. So based on this, I think it's probably safe to just follow the Go release policy: "Each major Go release is supported until there are two newer major releases." This will allow merging #554
arp242
added a commit
that referenced
this pull request
Feb 9, 2023
I have no idea if anyone is using Go 1.16 with fsnotify. Go 1.16 (released August 2021) became mandatory with v1.5.1 (August 2021). Go 1.17 was released just a few days before it was tagged. Some people did experience problems (#400), but overall the feedback was limited. So based on this, I think it's probably safe to just follow the Go release policy: "Each major Go release is supported until there are two newer major releases." This will allow merging #554
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Remove
retractdirective.The
retractdirective only works Go >= 1.16. The versions under that can't recognize the directive and cause an error. (e.g. https://github.com/fsnotify/fsnotify/runs/3414923756)So removed the directive to work builds.
Where should the reviewer start?
Please see CI passes.
How should this be manually tested?
No need.