Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Add AddRaw to not follow symlinks #394

Merged
merged 1 commit into from Aug 24, 2021
Merged

Revert Add AddRaw to not follow symlinks #394

merged 1 commit into from Aug 24, 2021

Conversation

nathany
Copy link
Contributor

@nathany nathany commented Aug 24, 2021

What does this pull request do?

Revert #289 to resolve regressions in #390 #393 #389.

We can give it another go. @Code0x58.

Where should the reviewer start?

How should this be manually tested?

go test

Copy link
Contributor

@nshalman nshalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This revert is fine. We should probably also update go.mod to retract v1.5.0

See https://golangtutorial.dev/tips/retract-go-module-versions/

@nathany nathany merged commit b98ede5 into master Aug 24, 2021
@nathany nathany deleted the revert branch August 24, 2021 19:25
eliobischof added a commit to caos/orbos that referenced this pull request Aug 30, 2021
eliobischof added a commit to caos/orbos that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants